Add a promise for app_initialized event.#2710
Merged
takluyver merged 2 commits intojupyter:masterfrom Aug 1, 2017
Merged
Conversation
minrk
approved these changes
Jul 31, 2017
Member
|
Seems like a good solution to me. |
Contributor
|
Looks good to me. Should we update the custom.js docs? |
Member
|
@gnestor good call. I pushed an update to custom.js |
minrk
approved these changes
Aug 1, 2017
Member
Author
|
Thanks - I was just about to look at it, so you saved me a few minutes. :-) |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See gh-2499
The idea is that custom.js code which was previously listening for
app_initialized.NotebookAppevents can do this instead:I've milestoned this for 5.1 so that we consider it, as I think this is the answer to a long-running annoyance with the event firing before the code listens for it. But I don't mind if we decide to push it back to a later release.